lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230302111909.721352cf@md1za8fc.ad001.siemens.net>
Date:   Thu, 2 Mar 2023 11:19:09 +0100
From:   Henning Schild <henning.schild@...mens.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up

Am Wed, 1 Mar 2023 19:30:38 +0200
schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:

> On Wed, Mar 01, 2023 at 06:02:12PM +0100, Henning Schild wrote:
> 
> > This series mainly splits the one GPIO driver into two. The split
> > allows to clearly model runtime and compile time dependencies on
> > the GPIO chip drivers.
> > 
> > p1 is kind of not too related to that split but also prepares for
> > more GPIO based drivers to come.
> > 
> > p2 takes the driver we had and puts some of its content into a
> > -core, to be used by the two drivers.
> > 
> > p3 deals with more fine-grained configuration posibilities and
> > compile time dependencies.
> > 
> > It is based on
> > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO
> > providing driver  
> 
> Thank you for an update.
> Not big issues found (except maybe the Makefile).
> 

The Makefile does work with all Y. So if that was all that was open,
and the rest is just optional improvement. I would be happy if this can
be merged as is, and deal with improvements later.

Thanks!

Henning

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ