linux-kernel - Re: [PATCH 6.1 00/42] 6.1.15-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZAB6pP3MNy152f+7@kroah.com>
Date:   Thu, 2 Mar 2023 11:29:56 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        mptcp@...ts.linux.dev, Florian Westphal <fw@...len.de>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH 6.1 00/42] 6.1.15-rc1 review

On Thu, Mar 02, 2023 at 03:49:31PM +0530, Naresh Kamboju wrote:
> On Wed, 1 Mar 2023 at 23:42, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.1.15 release.
> > There are 42 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 03 Mar 2023 18:06:43 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.15-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> Regression found on Linux version 6.1.15-rc1 on 32-bit arm x15 and i386.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> 
> ## Build
> * kernel: 6.1.15-rc1
> * git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
> * git branch: linux-6.1.y
> * git commit: b6150251d4ddf8a80510c185d839631e252e6317
> * git describe: v6.1.14-43-gb6150251d4dd
> * test details:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.14-43-gb6150251d4dd
> 
> Regression test cases,
> i386:
> x15:
>   * kselftest-net-mptcp/net_mptcp_mptcp_sockopt_sh
> 
> # mptcp_sockopt: mptcp_sockopt.c:353: do_getsockopt_tcp_info:
> Assertion `ti.d.size_user == sizeof(struct tcp_info)' failed.
> # mptcp_sockopt: mptcp_sockopt.c:353: do_getsockopt_tcp_info:
> Assertion `ti.d.size_user == sizeof(struct tcp_info)' failed.
> 
> test log:
> ----------
> 
> # selftests: net/mptcp: mptcp_sockopt.sh
> [  918.263983] IPv6: ADDRCONF(NETDEV_CHANGE): ns1eth1: link becomes ready
> [  918.398851] IPv6: ADDRCONF(NETDEV_CHANGE): ns1eth2: link becomes ready
> [  918.538987] IPv6: ADDRCONF(NETDEV_CHANGE): ns1eth3: link becomes ready
> [  918.678270] IPv6: ADDRCONF(NETDEV_CHANGE): ns1eth4: link becomes ready
> [  918.800671] audit: type=1325 audit(1677748585.128:33): table=filter
> family=2 entries=0 op=xt_register pid=18489 subj=kernel
> comm=\"iptables\"
> [  918.813228] audit: type=1300 audit(1677748585.128:33):
> arch=40000003 syscall=102 success=yes exit=0 a0=f a1=bf94ed3c a2=40
> a3=b7edfe3c items=0 ppid=18412 pid=18489 auid=4294967295 uid=0 gid=0
> euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=ttyS0 ses=4294967295
> comm=\"iptables\" exe=\"/usr/sbin/xtables-legacy-multi\" subj=kernel
> key=(null)
> [  918.842987] audit: type=1327 audit(1677748585.128:33):
> proctitle=69707461626C6573002D41004F5554505554002D7000746370002D2D73796E002D6D006D61726B002D2D6D61726B0031002D6A00414343455054
> [  918.859285] audit: type=1325 audit(1677748585.128:34): table=filter
> family=2 entries=4 op=xt_replace pid=18489 subj=kernel
> comm=\"iptables\"
> [  918.871788] audit: type=1300 audit(1677748585.128:34):
> arch=40000003 syscall=102 success=yes exit=0 a0=e a1=bf94ef64 a2=40
> a3=b7edfe3c items=0 ppid=18412 pid=18489 auid=4294967295 uid=0 gid=0
> euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=ttyS0 ses=4294967295
> comm=\"iptables\" exe=\"/usr/sbin/xtables-legacy-multi\" subj=kernel
> key=(null)
> [  918.901496] audit: type=1327 audit(1677748585.128:34):
> proctitle=69707461626C6573002D41004F5554505554002D7000746370002D2D73796E002D6D006D61726B002D2D6D61726B0031002D6A00414343455054
> [  918.934555] audit: type=1325 audit(1677748585.262:35): table=filter
> family=2 entries=5 op=xt_replace pid=18490 subj=kernel
> comm=\"iptables\"
> [  918.947242] audit: type=1300 audit(1677748585.262:35):
> arch=40000003 syscall=102 success=yes exit=0 a0=e a1=bfc21cd4 a2=40
> a3=b7f27e3c items=0 ppid=18412 pid=18490 auid=4294967295 uid=0 gid=0
> euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=ttyS0 ses=4294967295
> comm=\"iptables\" exe=\"/usr/sbin/xtables-legacy-multi\" subj=kernel
> key=(null)
> [  918.976905] audit: type=1327 audit(1677748585.262:35):
> proctitle=69707461626C6573002D41004F5554505554002D7000746370002D2D7463702D666C6167730052535400525354002D6D006D61726B002D2D6D61726B0030002D6A00414343455054
> [  919.013445] audit: type=1325 audit(1677748585.341:36): table=filter
> family=2 entries=6 op=xt_replace pid=18491 subj=kernel
> comm=\"iptables\"
> # Created /tmp/tmp.CG4evZjYl7 (size 1 KB) containing data sent by client
> # Created /tmp/tmp.urARJfNrFp (size 1 KB) containing data sent by server
> # PASS: all packets had packet mark set
> # mptcp_[  944.426054] kauditd_printk_skb: 50 callbacks suppressed
> sockopt: mptcp_s[  944.426057] audit: type=1701
> audit(1677748610.753:53): auid=4294967295 uid=0 gid=0 ses=4294967295
> subj=kernel pid=18532 comm=\"mptcp_sockopt\"
> exe=\"/opt/kselftests/default-in-kernel/net/mptcp/mptcp_sockopt\"
> sig=6 res=1
> [  944.452415] audit: type=1701 audit(1677748610.753:54):
> auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=18533
> comm=\"mptcp_sockopt\"
> exe=\"/opt/kselftests/default-in-kernel/net/mptcp/mptcp_sockopt\"
> sig=6 res=1
> ockopt.c:353: do_getsockopt_tcp_info: Assertion `ti.d.size_user ==
> sizeof(struct tcp_info)' failed.


Nit, wrapping a log like this makes it hard to read, don't you think?

> # mptcp_sockopt: mptcp_sockopt.c:353: do_getsockopt_tcp_info:
> Assertion `ti.d.size_user == sizeof(struct tcp_info)' failed.
> # server killed by signal 6
> #
> # FAIL: SOL_MPTCP getsockopt
> # PASS: TCP_INQ cmsg/ioctl -t tcp
> # PASS: TCP_INQ cmsg/ioctl -6 -t tcp
> # PASS: TCP_INQ cmsg/ioctl -r tcp
> # PASS: TCP_INQ cmsg/ioctl -6 -r tcp
> # PASS: TCP_INQ cmsg/ioctl -r tcp -t tcp
> not ok 6 selftests: net/mptcp: mptcp_sockopt.sh # exit=1

Any chance you can bisect?

And is this an issue on 6.2 and/or Linus's tree?  I don't see any mptcp
changes in this 6.1-rc cycle, they were in the last one...

thanks,

greg k-h