linux-kernel - Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhJPsUYR55aLNWi-VC2wmNEZZj=7E1aPpFTB6a+Bzhw=E4y5g@mail.gmail.com>
Date:   Thu, 2 Mar 2023 19:11:28 +0800
From:   Kelvin Cheung <keguang.zhang@...il.com>
To:     andy.shevchenko@...il.com
Cc:     linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct

On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@...il.com> wrote:
>
> Wed, Feb 22, 2023 at 07:12:11PM +0800, Keguang Zhang kirjoitti:
> > Introduce and allocate ls1x_gpio_chip struct containing
> > gpio_chip and reg_base to avoid global gpio_reg_base.
> >
> > Use readl() & writel() instead of __raw_readl() & __raw_writel().
>
> Please, split this to two pathes.
>
Sure.
Thanks!

> --
> With Best Regards,
> Andy Shevchenko
>
>


-- 
Best regards,

Kelvin Cheung