linux-kernel - Re: [PATCH 0/2] tracing: Fix adding some modifiers to histogram values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230302081855.7ee88b32@gandalf.local.home>
Date:   Thu, 2 Mar 2023 08:18:55 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tom Zanussi <zanussi@...nel.org>
Subject: Re: [PATCH 0/2] tracing: Fix adding some modifiers to histogram
 values


I forgot to add Tom Zanussi on this series.

-- Steve


On Wed, 01 Mar 2023 20:00:51 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> Mark Rutland reported to me on IRC that he accidentally added the
> ".buckets=8" modifier to hitcount. This should not be allowed, but it
> did not error. Worse yet, when reading the hist file, it would crash
> as there was a NULL pointer dereference due to the values not having
> fields assigned to them.
> 
> The first fix is to make sure that histogram values do not get assigned
> modifiers that they can't use.
> 
> The the second patch is to not crash if a NULL pointer is passed to
> hist_field_name() (which is what happens if you allow some of these
> modifiers to be used by values).
> 
> Steven Rostedt (Google) (2):
>       tracing: Do not let histogram values have some modifiers
>       tracing: Check field value in hist_field_name()
> 
> ----
>  kernel/trace/trace_events_hist.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)