linux-kernel - Re: [PATCH 4/4] kmsan: add memsetXX tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=VjYhMrXuAR=tyXeC6-wTYA+EmkHQZf5nGwCCKwpApjUQ@mail.gmail.com>
Date:   Thu, 2 Mar 2023 15:14:07 +0100
From:   Alexander Potapenko <glider@...gle.com>
To:     Marco Elver <elver@...gle.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        dave.hansen@...ux.intel.com, hpa@...or.com,
        akpm@...ux-foundation.org, dvyukov@...gle.com, nathan@...nel.org,
        ndesaulniers@...gle.com, kasan-dev@...glegroups.com
Subject: Re: [PATCH 4/4] kmsan: add memsetXX tests

On Thu, Mar 2, 2023 at 12:23 PM Marco Elver <elver@...gle.com> wrote:
>
> On Wed, 1 Mar 2023 at 15:39, Alexander Potapenko <glider@...gle.com> wrote:
> >
> > Add tests ensuring that memset16()/memset32()/memset64() are
> > instrumented by KMSAN and correctly initialize the memory.
> >
> > Signed-off-by: Alexander Potapenko <glider@...gle.com>
> > ---
> >  mm/kmsan/kmsan_test.c | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c
> > index cc98a3f4e0899..e450a000441fb 100644
> > --- a/mm/kmsan/kmsan_test.c
> > +++ b/mm/kmsan/kmsan_test.c
> > @@ -503,6 +503,25 @@ static void test_memcpy_aligned_to_unaligned2(struct kunit *test)
> >         KUNIT_EXPECT_TRUE(test, report_matches(&expect));
> >  }
> >
> > +/* Generate test cases for memset16(), memset32(), memset64(). */
> > +#define DEFINE_TEST_MEMSETXX(size, var_ty)                                  \
> > +       static void test_memset##size(struct kunit *test)                   \
> > +       {                                                                   \
> > +               EXPECTATION_NO_REPORT(expect);                              \
> > +               volatile var_ty uninit;                                     \
>
> This could just be 'uint##size##_t' and you can drop 'var_ty'.

Indeed, thanks!