linux-kernel - Re: [PATCH v2 1/2] dt-bindings: leds: add binding for aw200xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a4abcc5-5246-20ac-e25b-f88ee90c1331@sberdevices.ru>
Date:   Thu, 2 Mar 2023 19:02:28 +0300
From:   Martin Kurbanov <mmkurbanov@...rdevices.ru>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
CC:     <linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...rdevices.ru>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: add binding for aw200xx

On 2023-03-02 10:48, Krzysztof Kozlowski wrote:

>> +  For more product information please see the link below:
>> +  aw20036 - https://www.awinic.com/Public/Uploads/uploadfile/files/20200509/20200509151532_5eb65894d205a.pdf
>> +  aw20054 - https://www.awinic.com/Public/Uploads/uploadfile/files/20200509/20200509151602_5eb658b2b77cb.pdf
>> +  aw20072 - https://www.awinic.com/Public/Uploads/uploadfile/files/20200509/20200509151754_5eb659227a145.pdf
> 
> Links do not work. Error 401

They are changed the links. I will correct in the next version.

>> +  awinic,display-rows:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description:
>> +      Leds matrix size
> 
> Why do you need this property? Number of LEDs are known from the number
> of children. Matrix size is fixed in compatible, isn't it?

Number of LEDs are known, but matrix size are programmable.
Example for the aw20036, the matrix size can be 1x12, 2x12, 3x12.

-- 
Best Regards,
Kurbanov Martin