linux-kernel - Re: [PATCH] cxl/hdm: Fix hdm decoder init by adding COMMIT field check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e17d59b0-ac81-8c7a-be0b-40eb419193c6@intel.com>
Date:   Thu, 2 Mar 2023 10:02:13 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     Fan Ni <fan.ni@...sung.com>,
        "alison.schofield@...el.com" <alison.schofield@...el.com>,
        "vishal.l.verma@...el.com" <vishal.l.verma@...el.com>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        "bwidawsk@...nel.org" <bwidawsk@...nel.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
        Adam Manzanares <a.manzanares@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/hdm: Fix hdm decoder init by adding COMMIT field
 check



On 3/2/23 9:28 AM, Davidlohr Bueso wrote:
> On Thu, 02 Mar 2023, Dave Jiang wrote:
> 
>> It does sound like a bug with QEMU emulation currently.
> 
> Agreed, but still, crashing the kernel is always a no no - like with
> the passthrough decoder situation we had.

I wonder if we are missing a check in cxl_decoder_commit() to exit if 
COMMITTED bit is set in register. The current code just blindly start 
programming the registers.

> 
> Thanks,
> Davidlohr