linux-kernel - Re: [PATCH 5/5] clk: hisilicon: Add CRG driver for Hi3798MV100 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 21:24:45 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     David Yang <mmyangfl@...il.com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] clk: hisilicon: Add CRG driver for Hi3798MV100 SoC

On 03/03/2023 16:14, David Yang wrote:
> Add CRG driver for Hi3798MV100 SoC. CRG (Clock and Reset Generator) module
> generates clock and reset signals used by other module blocks on SoC.
> 
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
>  .../devicetree/bindings/clock/hisi-crg.txt    |   2 +
>  drivers/clk/hisilicon/crg-hi3798.c            | 193 ++++++++++++++++--
>  include/dt-bindings/clock/histb-clock.h       |  11 +

No. Don't mix bindings and code.

Run checkpatch - you should get warnings for this (and such you must
fix, not ignore).

Best regards,
Krzysztof