linux-kernel - Re: [PATCH] selftests: ir: add config file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 13:42:41 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Anders Roxell <anders.roxell@...aro.org>, shuah@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: ir: add config file

On 2/21/23 00:03, Anders Roxell wrote:
> Building and running the subsuite 'ir' of kselftest, shows the
> following issues:
>   ir_loopback: module rc-loopback is not found in /lib/modules/6.2.0-rc8-next-20230220 [SKIP]
> 

Why is this an issue? I am not saying this patch isn't necessary.
But the behavior above is valid behavior when config options
aren't enabled?

Perhaps the commit log could reflect that adding config file
with the right options allows the test to run as opposed to
describing a valid behavior is an issue.

> By creating a config file with RC_LOOPBACK=m, LIRC=y and a few
> IR_*DECODER=m in the selftests/ir/ directory the tests pass.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>   tools/testing/selftests/ir/config | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>   create mode 100644 tools/testing/selftests/ir/config
> 
> diff --git a/tools/testing/selftests/ir/config b/tools/testing/selftests/ir/config
> new file mode 100644
> index 000000000000..a6031914fa3d
> --- /dev/null
> +++ b/tools/testing/selftests/ir/config
> @@ -0,0 +1,13 @@
> +CONFIG_LIRC=y
> +CONFIG_IR_IMON_DECODER=m
> +CONFIG_IR_JVC_DECODER=m
> +CONFIG_IR_MCE_KBD_DECODER=m
> +CONFIG_IR_NEC_DECODER=m
> +CONFIG_IR_RC5_DECODER=m
> +CONFIG_IR_RC6_DECODER=m
> +CONFIG_IR_RCMM_DECODER=m
> +CONFIG_IR_SANYO_DECODER=m
> +CONFIG_IR_SHARP_DECODER=m
> +CONFIG_IR_SONY_DECODER=m
> +CONFIG_IR_XMP_DECODER=m
> +CONFIG_RC_LOOPBACK=m

thanks,
-- Shuah