linux-kernel - [PATCH] Error checking for spi_setup during probe function added to rtc-m41t94 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat,  4 Mar 2023 05:45:26 +0800
From:   Nur Hussein <hussein@...xcat.org>
To:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Nur Hussein <hussein@...xcat.org>
Subject: [PATCH] Error checking for spi_setup during probe function added to rtc-m41t94 driver

The m41t94_probe() function calls spi_setup() but does not check for an
error upon return. I have added this check, and returns the error and
sets the error message via dev_error to "spi_setup failed".

Signed-off-by: Nur Hussein <hussein@...xcat.org>
---
 drivers/rtc/rtc-m41t94.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-m41t94.c b/drivers/rtc/rtc-m41t94.c
index 6803b0273302..4bdee2336228 100644
--- a/drivers/rtc/rtc-m41t94.c
+++ b/drivers/rtc/rtc-m41t94.c
@@ -112,7 +112,12 @@ static int m41t94_probe(struct spi_device *spi)
 	int res;
 
 	spi->bits_per_word = 8;
-	spi_setup(spi);
+
+	res = spi_setup(spi);
+	if (res < 0) {
+		dev_err(&spi->dev, "spi setup failed.\n");
+		return res;
+	}
 
 	res = spi_w8r8(spi, M41T94_REG_SECONDS);
 	if (res < 0) {
-- 
2.34.1