[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 2 Mar 2023 21:07:31 -0300
From: Martin Rodriguez Reboredo <yakoyoku@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Derek Barbosa <debarbos@...hat.com>,
rust-for-linux@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] rust: bindgen: Add `alt_instr` as opaque type
On 3/2/23 18:02, Miguel Ojeda wrote:
> On Thu, Mar 2, 2023 at 3:59 PM Martin Rodriguez Reboredo
> <yakoyoku@...il.com> wrote:
>>
>> Still, we have to be careful if these kind of things appear in
>> the future.
>
> Not entirely sure what you mean -- do you mean if some Rust
> abstractions used its fields? But if we were in that case, it would
> not compile, so we would notice. Or what do you mean?
>
I've meant a general case with any abstraction, but that would be
noticed right away.
>> And I notice that You haven't mentioned the version of Bindgen that
>> You've used, including its linked libclang too. Otherwise I think this
>> could be accepted.
>
> I could reproduce this with the expected versions. Since, for now,
> those are the only ones supported and the build system emits a warning
> otherwise, I think it is fair to assume those versions were used
> unless otherwise stated.
>
> Cheers,
> Miguel
Sounds fair.
Powered by blists - more mailing lists