[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 3 Mar 2023 06:53:19 +0000
From: "Liu, Yi L" <yi.l.liu@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>,
"jgg@...dia.com" <jgg@...dia.com>,
"Tian, Kevin" <kevin.tian@...el.com>,
"joro@...tes.org" <joro@...tes.org>,
"will@...nel.org" <will@...nel.org>,
"robin.murphy@....com" <robin.murphy@....com>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
"shuah@...nel.org" <shuah@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
"mjrosato@...ux.ibm.com" <mjrosato@...ux.ibm.com>,
"farman@...ux.ibm.com" <farman@...ux.ibm.com>
Subject: RE: [PATCH v3 1/5] vfio: Do not allow !ops->dma_unmap in
vfio_pin/unpin_pages()
> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Saturday, February 25, 2023 9:52 AM
>
> A driver that doesn't implement ops->dma_unmap shouldn't be allowed to
> do
> vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova
> range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages().
>
> Suggested-by: Kevin Tian <kevin.tian@...el.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
Reviewed-by: Yi Liu <yi.l.liu@...el.com>
> ---
> drivers/vfio/vfio_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
> index 43bd6b76e2b6..0381f6e7f4e6 100644
> --- a/drivers/vfio/vfio_main.c
> +++ b/drivers/vfio/vfio_main.c
> @@ -1292,6 +1292,8 @@ int vfio_pin_pages(struct vfio_device *device,
> dma_addr_t iova,
> /* group->container cannot change while a vfio device is open */
> if (!pages || !npage ||
> WARN_ON(!vfio_assert_device_open(device)))
> return -EINVAL;
> + if (!device->ops->dma_unmap)
> + return -EINVAL;
> if (vfio_device_has_container(device))
> return vfio_device_container_pin_pages(device, iova,
> npage, prot, pages);
> @@ -1329,6 +1331,8 @@ void vfio_unpin_pages(struct vfio_device *device,
> dma_addr_t iova, int npage)
> {
> if (WARN_ON(!vfio_assert_device_open(device)))
> return;
> + if (WARN_ON(!device->ops->dma_unmap))
> + return;
>
> if (vfio_device_has_container(device)) {
> vfio_device_container_unpin_pages(device, iova, npage);
> --
> 2.39.2
Powered by blists - more mailing lists