linux-kernel - Re: [PATCH v1 11/11] media: starfive: enable building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 09:43:27 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "jack.zhu" <jack.zhu@...rfivetech.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, changhuang.liang@...rfivetech.com
Subject: Re: [PATCH v1 11/11] media: starfive: enable building

On 02/03/2023 10:19, jack.zhu wrote:
> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile
> to enable building of the Starfive Camera subsystem driver.
> 
> Signed-off-by: jack.zhu <jack.zhu@...rfivetech.com>
> ---
>  drivers/media/platform/Kconfig           |  1 +
>  drivers/media/platform/Makefile          |  1 +
>  drivers/media/platform/starfive/Kconfig  | 18 ++++++++++++++++++
>  drivers/media/platform/starfive/Makefile | 14 ++++++++++++++

This is not a separate commit. If it were, it would mean you just added
dead code in previous commits, so why adding dead code in first place?

Squash it.

Best regards,
Krzysztof