linux-kernel - Re: [PATCH 19/27] irqchip/mchp-eic: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 11:23:31 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <nick.alcock@...cle.com>, <mcgrof@...nel.org>
CC:     <linux-modules@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hasegawa-hitomi@...itsu.com>, <tglx@...utronix.de>,
        <maz@...nel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 19/27] irqchip/mchp-eic: remove MODULE_LICENSE in
 non-modules

On 24.02.2023 17:08, Nick Alcock wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  drivers/irqchip/irq-mchp-eic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mchp-eic.c b/drivers/irqchip/irq-mchp-eic.c
> index c726a19837d2..5dcd94c000a2 100644
> --- a/drivers/irqchip/irq-mchp-eic.c
> +++ b/drivers/irqchip/irq-mchp-eic.c
> @@ -276,5 +276,4 @@ IRQCHIP_MATCH("microchip,sama7g5-eic", mchp_eic_init)
>  IRQCHIP_PLATFORM_DRIVER_END(mchp_eic)
> 
>  MODULE_DESCRIPTION("Microchip External Interrupt Controller");
> -MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Claudiu Beznea <claudiu.beznea@...rochip.com>");
> --
> 2.39.1.268.g9de2f9a303
>