linux-kernel - Re: [PATCH v2 9/9] crypto: ccp: Add doorbell register offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 12:57:07 +0100
From:   Grzegorz Bernacki <gjb@...ihalf.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Jan Dąbroś <jsd@...ihalf.com>,
        Rijo-john.Thomas@....com, Thomas.Lendacky@....com,
        herbert@...dor.apana.org.au, John Allen <john.allen@....com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 9/9] crypto: ccp: Add doorbell register offset

Hi Mario,

It won't work as expected since the Skyrim device has a different
offset of cmdresp_reg, which is 0x10a40 and doorbell is actually
0x10a24. I apologize for giving you the wrong values.
thanks,
greg

czw., 2 mar 2023 o 20:43 Mario Limonciello <mario.limonciello@....com>
napisał(a):
>
> The PSP in Skyrim uses i2c arbitration with a doorbell.
> Add this offset so that the communication can work.
>
> Link: Link: https://lore.kernel.org/linux-i2c/20220916131854.687371-3-jsd@semihalf.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v1->v2:
>  * New patch
> ---
>  drivers/crypto/ccp/sp-pci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 18aa902eb5ce..a4efcaee43d8 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -365,6 +365,7 @@ static const struct platform_access_vdata pa_v1 = {
>         .cmdresp_reg            = 0x10570,      /* C2PMSG_28 */
>         .cmdbuff_addr_lo_reg    = 0x10574,      /* C2PMSG_29 */
>         .cmdbuff_addr_hi_reg    = 0x10578,      /* C2PMSG_30 */
> +       .doorbell_reg           = 0x10a40,      /* C2PMSG_80 */
>  };
>
>  static const struct psp_vdata pspv1 = {
> --
> 2.34.1
>