[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 4 Mar 2023 01:21:43 +0900
From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>, rafael@...nel.org
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Niklas Söderlund
<niklas.soderlund+renesas@...natech.se>,
Mark Brown <broonie@...nel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Balsam CHIHI <bchihi@...libre.com>,
Adam Ward <DLG-Adam.Ward.opensource@...renesas.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Jernej Skrabec <jernej.skrabec@...il.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Florian Fainelli <f.fainelli@...il.com>,
Dhruva Gole <d-gole@...com>,
Guillaume La Roque <glaroque@...libre.com>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
Markus Mayer <mmayer@...adcom.com>,
Support Opensource <support.opensource@...semi.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Thara Gopinath <thara.gopinath@...il.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Niklas Söderlund <niklas.soderlund@...natech.se>,
Heiko Stuebner <heiko@...ech.de>,
Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Orson Zhai <orsonzhai@...il.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Vasily Khoruzhick <anarsoul@...il.com>,
Yangtao Li <tiny.windzz@...il.com>,
Chen-Yu Tsai <wens@...e.org>,
Samuel Holland <samuel@...lland.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Talel Shenhar <talel@...zon.com>,
Eduardo Valentin <edubezval@...il.com>,
Keerthy <j-keerthy@...com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Stefan Wahren <stefan.wahren@...e.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
ye xingchen <ye.xingchen@....com.cn>,
Zheng Yongjun <zhengyongjun3@...wei.com>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Davidlohr Bueso <dave@...olabs.net>,
Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>,
"Lee, Chun-Yi" <joeyli.kernel@...il.com>,
Shang XiaoJing <shangxiaojing@...wei.com>,
Tim Zimmermann <tim@...ux4.de>,
Yang Li <yang.lee@...ux.alibaba.com>,
Jiang Jian <jiangjian@...rlc.com>,
Daniel Golle <daniel@...rotopia.org>,
Randy Dunlap <rdunlap@...radead.org>,
Ido Schimmel <idosch@...dia.com>,
Minghao Chi <chi.minghao@....com.cn>,
Johan Hovold <johan+linaro@...nel.org>,
Mikko Perttunen <mperttunen@...dia.com>,
"open list:THERMAL DRIVER FOR AMLOGIC SOCS"
<linux-amlogic@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
"open list:QUALCOMM TSENS THERMAL DRIVER"
<linux-arm-msm@...r.kernel.org>,
"open list:RENESAS R-CAR THERMAL DRIVERS"
<linux-renesas-soc@...r.kernel.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@...ts.infradead.org>,
"open list:SAMSUNG THERMAL DRIVER"
<linux-samsung-soc@...r.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@...md-mailman.stormreply.com>,
"open list:ARM/Allwinner sunXi SoC support"
<linux-sunxi@...ts.linux.dev>,
"open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
"open list:TI BANDGAP AND THERMAL DRIVER"
<linux-omap@...r.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v5 02/18] thermal/core: Use the thermal zone 'devdata'
accessor in thermal located drivers
On 2023/03/02 5:14, Daniel Lezcano wrote:
> The thermal zone device structure is exposed to the different drivers
> and obviously they access the internals while that should be
> restricted to the core thermal code.
>
> In order to self-encapsulate the thermal core code, we need to prevent
> the drivers accessing directly the thermal zone structure and provide
> accessor functions to deal with.
>
> Use the devdata accessor introduced in the previous patch.
>
> No functional changes intended.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se> #R-Car
> Acked-by: Mark Brown <broonie@...nel.org>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> #MediaTek auxadc and lvts
> Reviewed-by: Balsam CHIHI <bchihi@...libre.com> #Mediatek lvts
> Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@...renesas.com> #da9062
> Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com> #spread
> Acked-by: Jernej Skrabec <jernej.skrabec@...il.com> #sun8i_thermal
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Acked-by: Florian Fainelli <f.fainelli@...il.com> #Broadcom
> Reviewed-by: Dhruva Gole <d-gole@...com> # K3 bandgap
(snip)
> diff --git a/drivers/thermal/uniphier_thermal.c
> b/drivers/thermal/uniphier_thermal.c
> index 47801841b3f5..aef6119cc004 100644
> --- a/drivers/thermal/uniphier_thermal.c
> +++ b/drivers/thermal/uniphier_thermal.c
> @@ -187,7 +187,7 @@ static void uniphier_tm_disable_sensor(struct
> uniphier_tm_dev *tdev)
>
> static int uniphier_tm_get_temp(struct thermal_zone_device *tz, int
> *out_temp)
> {
> - struct uniphier_tm_dev *tdev = tz->devdata;
> + struct uniphier_tm_dev *tdev = thermal_zone_device_priv(tz);
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com> #uniphier
Thank you,
---
Best Regards
Kunihiko Hayashi
Powered by blists - more mailing lists