linux-kernel - Re: [PATCH 05/17] drivers: bus: simple-pm-bus: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Mar 2023 18:32:04 +0000
From:   Nick Alcock <nick.alcock@...cle.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     mcgrof@...nel.org, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
Subject: Re: [PATCH 05/17] drivers: bus: simple-pm-bus: remove
 MODULE_LICENSE in non-modules

On 3 Mar 2023, Geert Uytterhoeven told this:

> On Thu, Mar 2, 2023 at 11:25 PM Nick Alcock <nick.alcock@...cle.com> wrote:
>> --- a/drivers/bus/simple-pm-bus.c
>> +++ b/drivers/bus/simple-pm-bus.c
>> @@ -92,4 +92,3 @@ module_platform_driver(simple_pm_bus_driver);
>>
>>  MODULE_DESCRIPTION("Simple Power-Managed Bus Driver");
>>  MODULE_AUTHOR("Geert Uytterhoeven <geert+renesas@...der.be>");
>> -MODULE_LICENSE("GPL v2");
>
> Please do not remove this line as long as the file has no SPDX-License
> tag.

I'll augment this patch with an SPDX addition, if you think that's OK,
which it sounds like you do. (MODULE_LICENSE has side effects these days
which a SPDX header does not, and those side effects are wrong for
things that cannot be modules.)