linux-kernel - Re: [PATCH] thermal: int340x: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 19:52:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     rafael@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...el.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] thermal: int340x: processor_thermal: Fix deadlock

On Fri, Mar 03, 2023 at 08:19:09AM -0800, Srinivas Pandruvada wrote:
> From: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
> 
> When user space updates the trip point there is a deadlock, which results
> in caller gets blocked forever.
> 
> Commit 05eeee2b51b4 ("thermal/core: Protect sysfs accesses to thermal
> operations with thermal zone mutex"), added a mutex for tz->lock in the
> function trip_point_temp_store(). Hence, trip set callback() can't
> call any thermal zone API as they are protected with the same mutex lock.
> 
> The callback here calling thermal_zone_device_enable(), which will result
> in deadlock.
> 
> Move the thermal_zone_device_enable() to proc_thermal_pci_probe() to
> avoid this deadlock.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
> Cc: stable@...r.kernel.org
> ---
> The commit which caused this issue was added during v6.2 cycle.

What commit exactly?  Always list that as a Fixes: tag if you know this.

thanks,

greg k-h