linux-kernel - Re: [PATCH 2/2] menuconfig: reclaim 1 more vertical line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae258f1e-5c44-d349-4704-fbf5c7c28b85@infradead.org>
Date:   Sat, 4 Mar 2023 09:52:55 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] menuconfig: reclaim 1 more vertical line

Hi,

On 3/4/23 08:56, Alexey Dobriyan wrote:
> Empty line after legend is waste, use it for config options.
> 

I don't see an empty line after the legend. For me this patch
truncates the menu_instructions[] text from 4 lines to 3 lines,
dropping good/useful help text.

menu_instructions[] was already truncated before this patch
(in an 80x30 size terminal window).

What size terminal are you using?

> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  scripts/kconfig/lxdialog/menubox.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -185,7 +185,7 @@ int dialog_menu(const char *title, const char *prompt,
>  
>  	height -= 2;
>  	width  -= 5;
> -	menu_height = height - 10;
> +	menu_height = height - 9;
>  
>  	max_choice = MIN(menu_height, item_count());
>  

-- 
~Randy