linux-kernel - Re: [PATCH v10 03/13] kbuild: add tristate checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASpkAY=t3uOmehTDD7o1-MY9Kzm1C=V2+i0XhHmjjJdUQ@mail.gmail.com>
Date:   Mon, 6 Mar 2023 00:10:22 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nick Alcock <nick.alcock@...cle.com>
Cc:     mcgrof@...nel.org, linux-modules@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, akpm@...ux-foundation.org, eugene.loh@...cle.com,
        kris.van.hees@...cle.com
Subject: Re: [PATCH v10 03/13] kbuild: add tristate checker

On Tue, Dec 6, 2022 at 1:32 AM Nick Alcock <nick.alcock@...cle.com> wrote:
>
> This new check target uses the tristate.conf machinery just added, and
> modules.builtin.objs, to identify source files that have MODULE_*
> declarations despite not being modules according to Kconfig.  After
> commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), all such declarations will cause
> modprobe to misidentify their containing object file as a module when it
> is not, which might cause it to spuriously fail when trying to load
> something that is built in to the kernel.




Having false-positives in modules.builtin should be OK.


Also, scripts/check-tristates.mk is just a rename of
scripts/Makefile.modbuiltin.


NACK.





--
Best Regards


Masahiro Yamada