linux-kernel - Re: [PATCH 1/5] mfd: Add support for Intel LJCA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230305103456.GF2574592@google.com>
Date:   Sun, 5 Mar 2023 10:34:56 +0000
From:   Lee Jones <lee@...nel.org>
To:     Ye Xiang <xiang.ye@...el.com>
Cc:     Wolfram Sang <wsa@...nel.org>, Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-gpio@...r.kernel.org, srinivas.pandruvada@...el.com,
        heikki.krogerus@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        sakari.ailus@...ux.intel.com, zhifeng.wang@...el.com,
        wentong.wu@...el.com, lixu.zhang@...el.com
Subject: Re: [PATCH 1/5] mfd: Add support for Intel LJCA device

On Mon, 20 Feb 2023, Ye Xiang wrote:

> This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
> device named "La Jolla Cove Adapter" (LJCA).

The "USB part" should live in drivers/usb.

You can use MFD to register each of the components, but all of the USB
functionality needs moving somewhere else.
 
> The communication between the various LJCA module drivers and the
> hardware will be muxed/demuxed by this driver. The sub-module of
> LJCA can use ljca_transfer() to issue a transfer between host
> and hardware.
> 
> Each sub-module of LJCA device is identified by type field within
> the LJCA message header.
> 
> The minimum code in ASL that covers this board is
> Scope (\_SB.PCI0.DWC3.RHUB.HS01)
>     {
>         Device (GPIO)
>         {
>             Name (_ADR, Zero)
>             Name (_STA, 0x0F)
>         }
> 
>         Device (I2C)
>         {
>             Name (_ADR, One)
>             Name (_STA, 0x0F)
>         }
> 
>         Device (SPI)
>         {
>             Name (_ADR, 0x02)
>             Name (_STA, 0x0F)
>         }
>     }
> 
> Signed-off-by: Ye Xiang <xiang.ye@...el.com>
> ---
>  drivers/mfd/Kconfig      |  13 +
>  drivers/mfd/Makefile     |   1 +
>  drivers/mfd/ljca.c       | 977 +++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/ljca.h |  95 ++++
>  4 files changed, 1086 insertions(+)
>  create mode 100644 drivers/mfd/ljca.c
>  create mode 100644 include/linux/mfd/ljca.h

-- 
Lee Jones [李琼斯]