linux-kernel - Re: Infinite loop in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e32e97858d5bf9d88cc03136d7abc7af2dd7f30.camel@perches.com>
Date:   Sun, 05 Mar 2023 16:05:18 -0800
From:   Joe Perches <joe@...ches.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     apw@...onical.com, dwaipayanray1@...il.com,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Infinite loop in checkpatch.pl

On Fri, 2023-03-03 at 21:53 +0100, Alexander Potapenko wrote:
> On Fri, Mar 3, 2023 at 5:53 PM Joe Perches <joe@...ches.com> wrote:
> > 
> > On Fri, 2023-03-03 at 15:28 +0100, Alexander Potapenko wrote:
> > > Hi folks,
> > > 
> > > I've noticed that checkpatch.pl chokes on the following file (also attached):
> > > 
> > > ==================================
> > > $ cat test-checkpatch.txt
> > > diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c
> > > @@ -504,6 +504,25 @@ static void
> > > test_memcpy_aligned_to_unaligned2(struct kunit *test)
> > > + EXPECTATION_NO_REPORT(expect);                              \
> > > + volatile uint##size##_t uninit;                             \
> > 
> > checkpatch isn't a syntax complete c parser.  Don't expect to be.
> 
> That's understandable, and I sure don't. But as a user I expect it to
> not loop infinitely, and I think that's also reasonable.
> The example I gave is not a randomly generated code snippet, but an
> excerpt from a valid patch that I sent earlier today:
> https://lore.kernel.org/lkml/20230303141433.3422671-4-glider@google.com/,
> which checkpatch cannot process.

I think this may be appropriate instead.  Andy W?
---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd44d12965c98..3328fb9f6d048 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -999,7 +999,9 @@ if (defined($typedefsfile)) {
 }
 
 sub build_types {
-	my $mods = "(?x:  \n" . join("|\n  ", (@modifierList, @modifierListFile)) . "\n)";
+	my $mods = "(?x:  \n" . join("|\n  ", @modifierList);
+	$mods .= "|(?^:  \n" . join("|\n  ", @modifierListFile) . "\n)" if ($#modifierListFile >= 0);
+	$mods .= ')';
 	my $all = "(?x:  \n" . join("|\n  ", (@typeList, @typeListFile)) . "\n)";
 	my $Misordered = "(?x:  \n" . join("|\n  ", @typeListMisordered) . "\n)";
 	my $allWithAttr = "(?x:  \n" . join("|\n  ", @typeListWithAttr) . "\n)";