linux-kernel - Re: [PATCH v3] Drivers: vmbus: Check for channel allocation before looking up relids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZAYGoSOZ407Wr18W@liuwe-devbox-debian-v2>
Date:   Mon, 6 Mar 2023 15:28:33 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     Mohammed Gamal <mgamal@...hat.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        "parri.andrea@...il.com" <parri.andrea@...il.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "xxiong@...hat.com" <xxiong@...hat.com>
Subject: Re: [PATCH v3] Drivers: vmbus: Check for channel allocation before
 looking up relids

On Mon, Feb 20, 2023 at 02:23:50PM +0000, Wei Liu wrote:
> On Fri, Feb 17, 2023 at 11:17:04PM +0000, Dexuan Cui wrote:
> > > From: Mohammed Gamal <mgamal@...hat.com>
> > > Sent: Friday, February 17, 2023 12:44 PM
> > > ...
> > > --- a/drivers/hv/connection.c
> > > +++ b/drivers/hv/connection.c
> > > @@ -409,6 +409,10 @@ void vmbus_disconnect(void)
> > >   */
> > >  struct vmbus_channel *relid2channel(u32 relid)
> > >  {
> > > +	if (vmbus_connection.channels == NULL) {
> > > +		pr_warn_once("relid2channel: relid=%d: No channels mapped!\n",
> > > relid);
> > 
> > Looks good to me except that the line exceeds 80 characters.
> > Please run "scripts/checkpatch.pl" to detect that.
> > For this patch, I guess Wei may be willing to help fix it.
> > 
> > > +		return NULL;
> > > +	}
> > >  	if (WARN_ON(relid >= MAX_CHANNEL_RELIDS))
> > >  		return NULL;
> > >  	return READ_ONCE(vmbus_connection.channels[relid]);
> > > --
> > 
> > Reviewed-by: Dexuan Cui <decui@...rosoft.com>
> 
> I will pick this up via hyperv-fixes.

Now applied to hyperv-fixes.

Thanks,
Wei.