linux-kernel - Re: [PATCH] f2fs: Fix f2fs_truncate_partial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230306111513.2aa49b1a@gandalf.local.home>
Date:   Mon, 6 Mar 2023 11:15:13 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Douglas RAILLARD <douglas.raillard@....com>
Cc:     Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-f2fs-devel@...ts.sourceforge.net (open list:F2FS FILE SYSTEM),
        linux-kernel@...r.kernel.org (open list:TRACING),
        linux-trace-kernel@...r.kernel.org (open list:TRACING)
Subject: Re: [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

On Mon,  6 Mar 2023 12:25:49 +0000
Douglas RAILLARD <douglas.raillard@....com> wrote:

> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index 31d994e6b4ca..8d053838d6cf 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -512,7 +512,7 @@ TRACE_EVENT(f2fs_truncate_partial_nodes,
>  	TP_STRUCT__entry(
>  		__field(dev_t,	dev)
>  		__field(ino_t,	ino)
> -		__field(nid_t,	nid[3])

That should not have even compiled. I'll see if I can add some tricks to
make that fail.

Thanks,

-- Steve


> +		__array(nid_t,	nid, 3)
>  		__field(int,	depth)
>  		__field(int,	err)
>  	),