linux-kernel - Re: [PATCH] clk: Print an info line before disabling unused clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230306171155.nry43s42l3rtdojo@SoMainline.org>
Date:   Mon, 6 Mar 2023 18:11:55 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org, Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: Print an info line before disabling unused clocks

On 2023-03-06 14:41:08, Konrad Dybcio wrote:
> Currently, the regulator framework informs us before calling into
> their unused cleanup paths, which eases at least some debugging. The
> same could be beneficial for clocks, so that random shutdowns shortly
> after most initcalls are done can be less of a guess.
> 
> Add a pr_info before disabling unused clocks to do so.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>  drivers/clk/clk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index ae07685c7588..827a51fe6653 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1404,7 +1404,8 @@ static int __init clk_disable_unused(void)
>  	if (clk_ignore_unused) {
>  		pr_warn("clk: Not disabling unused clocks\n");
>  		return 0;
> -	}
> +	} else

You shouldn't need an else here, as the if body above returns.  That
also aligns this pr_info with the actual code that performs the clk
disablement.

With that fxed, thanks a lot for this useful info in dmesg! Feel free to
add my r-b.

- Marijn

> +		pr_info("clk: Disabling unused clocks\n");
>  
>  	clk_prepare_lock();
>  
> -- 
> 2.39.2
>