linux-kernel - Re: [PATCH v1 1/2] dt-bindings: iio: adc: adding dt-bindings for PAC193X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6247adab-2004-5159-69ca-9e1dd30f4c38@kernel.org>
Date:   Mon, 6 Mar 2023 17:09:00 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Marius.Cristea@...rochip.com, jic23@...nel.org
Cc:     devicetree@...r.kernel.org, lars@...afoo.de,
        linux-iio@...r.kernel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: adc: adding dt-bindings for
 PAC193X

On 06/03/2023 14:53, Marius.Cristea@...rochip.com wrote:
> 
> Hi Jonathan,
> 
>    Thank you so much! I'm happy to contribute to IIO.
> 
> I will remove some section because I agree with the propose solution.
> For the rest I will comment below..
> 
> 
> 
> On Sat, 2023-02-25 at 17:17 +0000, Jonathan Cameron wrote:
>>>> +
>>>> +  microchip,samp-rate:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description: Sampling rate for all device's channels.
>>>
>>> What are the units? rate is usually in hz, which should be
>>> expressed in
>>> unit suffix (property name)]
>>
>> It's unusual for sampling rate to be a property of the hardware and
>> hence
>> suitable for DT binding. Normally we make this a userspace control
>> instead.
>> If there is a reason for doing it from DT, that wants to be mentioned
>> here.
>>
> 
> Here I could change it into the datarate (as in
> iio/adc/ti,ads1015.yaml). The units are samples per second. My
> intention was to be alingned with the datasheet.
> 
> My intention was to let the user configure the sample rate as soon as
> posile during the startup (the PAC device's own power consumtion will
> increase with the sampling rate - default the chip will start with the
> maximum samples per second).

Then maybe the default should be just lowest rate and user will adjust
it further? Since this is user-space knob, why this should be even
configurable per board?


Best regards,
Krzysztof