linux-kernel - Re: [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d97ab14301c65d775cd69c1efebedb37.sboyd@kernel.org>
Date:   Mon, 06 Mar 2023 11:30:36 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Riku Voipio <riku.voipio@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it

Quoting Randy Dunlap (2023-02-25 21:39:47)
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
> 
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
> 
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
> 
> Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Riku Voipio <riku.voipio@...aro.org>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: linux-clk@...r.kernel.org
> ---

Applied to clk-fixes