linux-kernel - Re: [PATCH -next 1/2] x86/mm/pat: Move follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ef7c77b-723c-461f-1d91-07a5b7701555@huawei.com>
Date:   Mon, 6 Mar 2023 17:17:53 +0800
From:   mawupeng <mawupeng1@...wei.com>
To:     <bp@...en8.de>
CC:     <mawupeng1@...wei.com>, <akpm@...ux-foundation.org>,
        <dave.hansen@...ux.intel.com>, <luto@...nel.org>,
        <peterz@...radead.org>, <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>
Subject: Re: [PATCH -next 1/2] x86/mm/pat: Move follow_phys to pat-related
 file



On 2023/3/6 17:04, Borislav Petkov wrote:
> On Mon, Mar 06, 2023 at 04:43:15PM +0800, Wupeng Ma wrote:
>> From: Ma Wupeng <mawupeng1@...wei.com>
>>
>> Since only PAT in x86 use follow_phys(), move this to from memory.c to
>> memtype.c and make it static. Argument flags is always zero in caller
>> untrack_pfn() and track_pfn_copy(). let's drop it.
>>
>> Since config HAVE_IOREMAP_PROT is selected by x86, drop this config macro.
> 
> * first patch: *only* code movement, no other changes
> * second patch: do semantic changes and explain *why* you do them
> * third patch:...
> *...
> 
> In that order please. Otherwise review is unnecessarily complicated.
> 
> Also, do not talk about *what* the patch is doing in the commit message
> - that should be obvious from the diff itself. Rather, concentrate on
> the *why* it needs to be done.

Hi Borislav.

Thanks for your advise.

I will do what you advised and send a v2 later.

> 
> Thx.
>