linux-kernel - Re: [PATCH] drivers: i2c: remove dead code in davinci_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2023 10:27:43 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Sekhar Nori <nsekhar@...com>, linux-arm-kernel@...ts.infradead.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: i2c: remove dead code in davinci_i2c_probe

On Mon, Mar 6, 2023 at 3:48 AM Dongliang Mu <dzm91@...t.edu.cn> wrote:
>
> From the comment of platform_get_irq, it only returns non-zero IRQ
> number and negative error number, other than zero.
>
> Fix this by removing the if condition.
>
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
>  drivers/i2c/busses/i2c-davinci.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index c836cf884185..9750310f2c96 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -764,11 +764,8 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>         int r, irq;
>
>         irq = platform_get_irq(pdev, 0);
> -       if (irq <= 0) {
> -               if (!irq)
> -                       irq = -ENXIO;
> +       if (irq < 0)
>                 return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
> -       }
>
>         dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
>                         GFP_KERNEL);
> --
> 2.39.2
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>