linux-kernel - Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1376c4bc859b17a2d40203747b8362108f29d9e.camel@mediatek.com>
Date:   Mon, 6 Mar 2023 09:33:18 +0000
From:   Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>
To:     "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Singo Chang (張興國) 
        <Singo.Chang@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        Nathan Lu (呂東霖) <Nathan.Lu@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        Rex-BC Chen (陳柏辰) 
        <Rex-BC.Chen@...iatek.com>
Subject: Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195
 mediatek-drm

Hi Angelo,

Thanks for the reviews and sorry for missing this mail :'(

I've resent v8 today:

https://patchwork.kernel.org/project/linux-mediatek/patch/20230306080659.15261-2-jason-jh.lin@mediatek.com/

Regards,
Jason-JH.Lin

On Wed, 2023-02-22 at 11:44 +0100, AngeloGioacchino Del Regno wrote:
> Il 27/12/22 08:47, Jason-JH.Lin ha scritto:
> > Because compatible of mt8195 is changing from "mediatek,mt8195-
> > mmsys"
> > to "mediatek,mt8195-vdosys0".
> > 
> > We have to revert the multiple compatible finding function and
> > add driver data of mt8195 vdosys0 to mediatek-drm and the sub
> > driver.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_disp_rdma.c |   6 ++
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c   | 128 +++---------------
> > -----
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.h   |   6 --
> >   3 files changed, 20 insertions(+), 120 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > index 0ec2e4049e07..66cdd0bc1311 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > @@ -370,6 +370,10 @@ static const struct mtk_disp_rdma_data
> > mt8183_rdma_driver_data = {
> >   	.fifo_size = 5 * SZ_1K,
> >   };
> >   
> > +static const struct mtk_disp_rdma_data mt8192_rdma_driver_data = {
> > +	.fifo_size = 5 * SZ_1K,
> > +};
> > +
> >   static const struct mtk_disp_rdma_data mt8195_rdma_driver_data =
> > {
> >   	.fifo_size = 1920,
> >   };
> > @@ -381,6 +385,8 @@ static const struct of_device_id
> > mtk_disp_rdma_driver_dt_match[] = {
> >   	  .data = &mt8173_rdma_driver_data},
> >   	{ .compatible = "mediatek,mt8183-disp-rdma",
> >   	  .data = &mt8183_rdma_driver_data},
> > +	{ .compatible = "mediatek,mt8192-disp-rdma",
> > +	  .data = &mt8192_rdma_driver_data},
> >   	{ .compatible = "mediatek,mt8195-disp-rdma",
> >   	  .data = &mt8195_rdma_driver_data},
> >   	{},
> 
> Can you please drop unrelated changes in mtk_disp_rdma.c and send a
> v8?
> We should aim to get this entire thing (8195 vdosys1) finally
> upstream.
> 
> 
> After dropping mtk_disp_rdma.c changes:
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> 
>