linux-kernel - Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAW6t7LKCBubfnx/@hovoldconsulting.com>
Date:   Mon, 6 Mar 2023 11:04:39 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Abel Vesa <abel.vesa@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Artur Świgoń <a.swigon@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration
 race

On Mon, Mar 06, 2023 at 11:39:33AM +0200, Abel Vesa wrote:
> On 23-03-06 10:34:34, Johan Hovold wrote:
> > On Mon, Mar 06, 2023 at 11:03:14AM +0200, Abel Vesa wrote:
> > > On 23-03-06 08:56:41, Johan Hovold wrote:
> > > > The current interconnect provider registration interface is inherently
> > > > racy as nodes are not added until the after adding the provider. This
> > > > can specifically cause racing DT lookups to fail.
> > > > 
> > > > Switch to using the new API where the provider is not registered until
> > > > after it has been fully initialised.
> > > > 
> > > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver")
> > > > Reviewed-by: Abel Vesa <abel.vesa@...aro.org>
> > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> > > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > > > ---
> > > 
> > > Any changes since v1 or is it just a resend? 
> > 
> > Please see the cover letter:
> > 
> > 	https://lore.kernel.org/lkml/20230306075651.2449-1-johan+linaro@kernel.org/
> > 
> > Only the first patch of the series was updated in v2.
> 
> Right, my bad. Though I wasn't CC'ed on that as well.

Yeah, sorry about that. I copied the CC list from v1 and forgot to make
sure that all reviewers were copied on the cover letter.

Johan