linux-kernel - Re: [PATCH] x86/kprobes: remove extern from arch_unoptimized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230306113028.8b36416af9f22805e5c2a46d@kernel.org>
Date:   Mon, 6 Mar 2023 11:30:28 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, yangjihong1@...wei.com,
        ast@...nel.org, peterz@...radead.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kprobes: remove extern from
 arch_unoptimized_kprobes

On Sat,  4 Mar 2023 09:15:44 -0500
Tom Rix <trix@...hat.com> wrote:

> smatch reports
> arch/x86/kernel/kprobes/opt.c:537:13: warning:
>   function 'arch_unoptimize_kprobes' with external linkage has definition
> 
> extern is only needed in a declaration, so remove it.

Thanks for pointing it out! This looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks, 

> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  arch/x86/kernel/kprobes/opt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
> index 57b0037d0a99..1e699deb77fe 100644
> --- a/arch/x86/kernel/kprobes/opt.c
> +++ b/arch/x86/kernel/kprobes/opt.c
> @@ -534,8 +534,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
>   * Recover original instructions and breakpoints from relative jumps.
>   * Caller must call with locking kprobe_mutex.
>   */
> -extern void arch_unoptimize_kprobes(struct list_head *oplist,
> -				    struct list_head *done_list)
> +void arch_unoptimize_kprobes(struct list_head *oplist,
> +			     struct list_head *done_list)
>  {
>  	struct optimized_kprobe *op, *tmp;
>  
> -- 
> 2.27.0
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>