linux-kernel - Re: [PATCH v5 0/2] erofs: set block size to the on-disk block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230306181123.000012ac.zbestahu@gmail.com>
Date:   Mon, 6 Mar 2023 18:11:23 +0800
From:   Yue Hu <zbestahu@...il.com>
To:     Jingbo Xu <jefflexu@...ux.alibaba.com>
Cc:     xiang@...nel.org, chao@...nel.org, linux-erofs@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, huyue2@...lpad.com
Subject: Re: [PATCH v5 0/2] erofs: set block size to the on-disk block size

On Mon,  6 Mar 2023 18:01:58 +0800
Jingbo Xu <jefflexu@...ux.alibaba.com> wrote:

> changes since v4:
> - patch 1: convert several remained call sites of sb->s_blocksize_bits
>   to erofs_blknr() and erofs_pos() (Yue Hu)
> - patch 2: revise comment for blkszbits and dirblkbits (Yue Hu)
> 
> changes since v3:
> - patch 1: remove redundant newline when printing messages (Gao Xiang)
> - patch 2: introduce dirblkbits in on-disk superblock and disable this
>   feature for now, so that the current kernel won't break with the image
>   with this feature enabled later (Gao Xiang)
> 
> 
> v1: https://lore.kernel.org/all/20230216094745.47868-1-jefflexu@linux.alibaba.com/
> v2: https://lore.kernel.org/all/20230217055016.71462-2-jefflexu@linux.alibaba.com/
> v3: https://lore.kernel.org/all/20230220025046.103777-1-jefflexu@linux.alibaba.com/
> v4: https://lore.kernel.org/all/20230302143915.111739-1-jefflexu@linux.alibaba.com/
> 
> 
> 
> Jingbo Xu (2):
>   erofs: avoid hardcoded blocksize for subpage block support
>   erofs: set block size to the on-disk block size
> 
>  fs/erofs/data.c              | 50 ++++++++++++++------------
>  fs/erofs/decompressor.c      |  6 ++--
>  fs/erofs/decompressor_lzma.c |  4 +--
>  fs/erofs/dir.c               | 22 ++++++------
>  fs/erofs/erofs_fs.h          |  5 +--
>  fs/erofs/fscache.c           |  5 +--
>  fs/erofs/inode.c             | 23 ++++++------
>  fs/erofs/internal.h          | 29 +++++----------
>  fs/erofs/namei.c             | 14 ++++----
>  fs/erofs/super.c             | 70 ++++++++++++++++++++++--------------
>  fs/erofs/xattr.c             | 40 ++++++++++-----------
>  fs/erofs/xattr.h             | 10 +++---
>  fs/erofs/zdata.c             | 18 +++++-----
>  fs/erofs/zmap.c              | 29 +++++++--------
>  include/trace/events/erofs.h |  4 +--
>  15 files changed, 170 insertions(+), 159 deletions(-)
> 

Reviewed-by: Yue Hu <huyue2@...lpad.com>