linux-kernel - Re: [PATCH 0/3] Add JH7110 USB driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAW/DqprkKaop4bg@wendy>
Date:   Mon, 6 Mar 2023 10:23:10 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Minda Chen <minda.chen@...rfivetech.com>
CC:     Emil Renner Berthing <kernel@...il.dk>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pawel Laszczak <pawell@...ence.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Chen <peter.chen@...nel.org>,
        Roger Quadros <rogerq@...nel.org>,
        Aswath Govindraju <a-govindraju@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Conor Dooley <conor@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <linux-usb@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 0/3] Add JH7110 USB driver support

Hey Minda!

On Mon, Mar 06, 2023 at 05:52:12PM +0800, Minda Chen wrote:
> This patchset adds USB driver for the StarFive JH7110 SoC.
> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
> The patch has been tested on the VisionFive 2 board.
> 
> This patchset should be applied after the patchset [1] and patch [2]:
> [1] https://lore.kernel.org/all/20230221083323.302471-1-xingyu.wu@starfivetech.com/
> [2] https://lore.kernel.org/all/20230215113249.47727-4-william.qiu@starfivetech.com/
> 
> patch 1 is usb phy dt-binding document.
> patch 2 is the glue layer of Cadence USB3 and USB phy
> setting. USB controller IP is Cadence USB3. 
> patch 3 is USB device tree configuration.
> 
> Minda Chen (3):
>   dt-bindings: phy: Add StarFive JH7110 USB dt-binding
>   usb: cdns3: add StarFive JH7110 USB glue layer
>   dts: usb: add StarFive JH7110 USB dts configuration.

Unfortunately, this patchset hasn't really landed correctly.
Usually, in a series, patches are sent as replies to the cover letter.
Git's send-email will do this for you if you pass it multiple patches
and a cover letter (I do it by passing a directory, eg patches/foo/v1)

It appears that you have sent each patch separately, and to different
recipients, which makes this harder to review.
Please re-submit this with proper threading (and as v2 ideally, so that
Greg's bot doesn't complain).

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)