[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230306025308.248987-1-dzm91@hust.edu.cn>
Date: Mon, 6 Mar 2023 10:53:07 +0800
From: Dongliang Mu <dzm91@...t.edu.cn>
To: Yinbo Zhu <zhuyinbo@...ngson.cn>
Cc: Dongliang Mu <dzm91@...t.edu.cn>, loongarch@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: [PATCH v2] drivers: loongson: fix memory leak in loongson2_guts_probe
drivers/soc/loongson/loongson2_guts.c:150 loongson2_guts_probe()
warn: 'guts->regs' from ioremap() not released on lines: 131,135,139,143.
Fix this by modifying ioremap to devm_ioremap.
Note that, this patch is not tested due to the loongson architecture.
Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
---
v1->v2: instead of modifying error handling code, directly change
ioremap to devm_ioremap.
drivers/soc/loongson/loongson2_guts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson/loongson2_guts.c
index bace4bc8e03b..a053e3fdae09 100644
--- a/drivers/soc/loongson/loongson2_guts.c
+++ b/drivers/soc/loongson/loongson2_guts.c
@@ -107,7 +107,7 @@ static int loongson2_guts_probe(struct platform_device *pdev)
guts->little_endian = of_property_read_bool(np, "little-endian");
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- guts->regs = ioremap(res->start, res->end - res->start + 1);
+ guts->regs = devm_ioremap(dev, res->start, res->end - res->start + 1);
if (IS_ERR(guts->regs))
return PTR_ERR(guts->regs);
--
2.39.2
Powered by blists - more mailing lists