linux-kernel - Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5DxXTUPHz-1crnr5McE40kW-we1b3pms5zn0UCvsnb82A@mail.gmail.com>
Date:   Mon, 6 Mar 2023 08:19:25 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     linux-imx@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a
 garbage value

On Mon, Mar 6, 2023 at 3:05 AM Ivan Bornyakov <i.bornyakov@...rotek.ru> wrote:
>
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>
> Cc: stable@...r.kernel.org

Please add a Fixes tag here.

Reviewed-by: Fabio Estevam <festevam@...il.com>