[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230306132526.8763-1-i.bornyakov@metrotek.ru>
Date: Mon, 6 Mar 2023 16:25:26 +0300
From: Ivan Bornyakov <i.bornyakov@...rotek.ru>
To: linux-imx@....com
Cc: Ivan Bornyakov <i.bornyakov@...rotek.ru>, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.
This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Signed-off-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc: stable@...r.kernel.org
Reviewed-by: Fabio Estevam <festevam@...il.com>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ChangeLog:
v1:
[https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/]
v2:
* add "Fixes" tag
* add Fabio's "Reviewed-by" tag
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..55d917bd1f3f 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
const struct of_device_id *of_id = of_match_device(weim_id_table,
&pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data;
+ int ret = 0, have_child = 0;
struct device_node *child;
- int ret, have_child = 0;
struct weim_priv *priv;
void __iomem *base;
u32 reg;
--
2.39.2
Powered by blists - more mailing lists