[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230306143528.7407fda5@xps-13>
Date: Mon, 6 Mar 2023 14:35:28 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Michael Walle <michael@...le.cc>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
Robert Marko <robert.marko@...tura.hr>,
Luka Perkov <luka.perkov@...tura.hr>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
rafal@...ecki.pl
Subject: Re: [PATCH 0/8] nvmem: Let layout drivers be modules
Hi Michael,
michael@...le.cc wrote on Mon, 06 Mar 2023 14:01:34 +0100:
> > Miquel Raynal (8):
> > of: Fix modalias string generation
> > of: Change of_device_get_modalias() main argument
> > of: Create an of_device_request_module() receiving an OF node
> > nvmem: core: Fix error path ordering
> > nvmem: core: Handle the absence of expected layouts
> > nvmem: core: Request layout modules loading
> > nvmem: layouts: sl28vpd: Convert layout driver into a module
> > nvmem: layouts: onie-tlv: Convert layout driver into a module
>
> With the fixes series [1] applied:
Thanks for the series! Looks good to me. I believe both series can live
in separate tress, any reason why we would like to avoid this? I am keen
to apply [1] into the mtd tree rather soon.
I will handle the remaining deferral errors in the regular mtd path as
discussed on IRC.
> Tested-by: Michael Walle <michael@...le.cc>
>
> I didn't test module autoloading, but I presume you did.
Yes, I generated an initramfs with Buildroot, in which an overlay
containing the result of modules_install got merged (storage device =y
and nvmem layout to =m). I could observe the modprobe call being
successful and the layout driver being loaded early.
> Thanks for working on this!
👍
> -michael
>
> [1] https://lore.kernel.org/r/20230306125805.678668-1-michael@walle.cc/
Thanks,
Miquèl
Powered by blists - more mailing lists