linux-kernel - Re: [PATCH] pinctrl: ocelot: Fix alt mode for ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZsWFJEU7xoc-r+tBkD2TzRTW34x3RbeqMEqrRfq6A7YA@mail.gmail.com>
Date:   Mon, 6 Mar 2023 15:18:40 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexandre.belloni@...tlin.com, andy.shevchenko@...il.com
Subject: Re: [PATCH] pinctrl: ocelot: Fix alt mode for ocelot

On Mon, Feb 6, 2023 at 9:37 PM Horatiu Vultur
<horatiu.vultur@...rochip.com> wrote:

> In case the driver was trying to set an alternate mode for gpio
> 0 or 32 then the mode was not set correctly. The reason is that
> there is computation error inside the function ocelot_pinmux_set_mux
> because in this case it was trying to shift to left by -1.
> Fix this by actually shifting the function bits and not the position.
>
> Fixes: 4b36082e2e09 ("pinctrl: ocelot: fix pinmuxing for pins after 31")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Patch applied for fixes.

Yours,
Linus Walleij