[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <PH0PR11MB5880550ED109DC115FC0EE17DAB69@PH0PR11MB5880.namprd11.prod.outlook.com>
Date: Mon, 6 Mar 2023 14:27:41 +0000
From: "Zhang, Qiang1" <qiang1.zhang@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: "mingo@...hat.com" <mingo@...hat.com>,
"vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
"juri.lelli@...hat.com" <juri.lelli@...hat.com>,
"dietmar.eggemann@....com" <dietmar.eggemann@....com>,
"rostedt@...dmis.org" <rostedt@...dmis.org>,
"vschneid@...hat.com" <vschneid@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] sched/fair: Make hrtimer callback execute in the hard
interrupt context
> The scheduler related hrtimers callback will be executed in softirqd
> context for PREEMPT_RT enabled kernel, this commit therefore mark
> hrtimers as harded even on PREEMPT_RT enabled kernels, there is no
> functional change.
>
>There very much is a functional change, also your reasoning is non-existant.
>
>Also:
Thanks for reply, I will reorganize the reason and resend
Thanks
Zqiang
>
> https://lkml.kernel.org/r/Y1F5sDVGen7ZVW+U@hirez.programming.kicks-ass.net
>
> Signed-off-by: Zqiang <qiang1.zhang@...el.com>
> ---
> kernel/sched/fair.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index
> c36aa54ae071..98c48d144089 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5610,7 +5610,7 @@ static void start_cfs_slack_bandwidth(struct
> cfs_bandwidth *cfs_b)
>
> hrtimer_start(&cfs_b->slack_timer,
> ns_to_ktime(cfs_bandwidth_slack_period),
> - HRTIMER_MODE_REL);
> + HRTIMER_MODE_REL_HARD);
> }
>
> /* we know any runtime found here is valid as update_curr() precedes
> return */ @@ -5813,9 +5813,9 @@ void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b)
> cfs_b->burst = 0;
>
> INIT_LIST_HEAD(&cfs_b->throttled_cfs_rq);
> - hrtimer_init(&cfs_b->period_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED);
> + hrtimer_init(&cfs_b->period_timer, CLOCK_MONOTONIC,
> +HRTIMER_MODE_ABS_PINNED_HARD);
> cfs_b->period_timer.function = sched_cfs_period_timer;
> - hrtimer_init(&cfs_b->slack_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> + hrtimer_init(&cfs_b->slack_timer, CLOCK_MONOTONIC,
> +HRTIMER_MODE_REL_HARD);
> cfs_b->slack_timer.function = sched_cfs_slack_timer;
> cfs_b->slack_started = false;
> }
> @@ -5835,7 +5835,7 @@ void start_cfs_bandwidth(struct cfs_bandwidth
> *cfs_b)
>
> cfs_b->period_active = 1;
> hrtimer_forward_now(&cfs_b->period_timer, cfs_b->period);
> - hrtimer_start_expires(&cfs_b->period_timer, HRTIMER_MODE_ABS_PINNED);
> + hrtimer_start_expires(&cfs_b->period_timer,
> +HRTIMER_MODE_ABS_PINNED_HARD);
> }
>
> static void destroy_cfs_bandwidth(struct cfs_bandwidth *cfs_b)
> --
> 2.25.1
>
Powered by blists - more mailing lists