[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e5733d0f-d5bb-deb5-20ff-649a9823ffa1@linux.alibaba.com>
Date: Mon, 6 Mar 2023 22:46:50 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Yue Hu <zbestahu@...il.com>, xiang@...nel.org, chao@...nel.org,
jefflexu@...ux.alibaba.com, linux-erofs@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org, huyue2@...lpad.com,
zhangwen@...lpad.com
Subject: Re: [PATCH] erofs: use wrapper i_blocksize() in
erofs_file_read_iter()
On 2023/3/6 15:55, Yue Hu wrote:
> From: Yue Hu <huyue2@...lpad.com>
>
> linux/fs.h has a wrapper for this operation.
>
> Signed-off-by: Yue Hu <huyue2@...lpad.com>
Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
Thanks,
Gao Xiang
> ---
> fs/erofs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 5bd0c956a142..7e8baf56faa5 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
> if (bdev)
> blksize_mask = bdev_logical_block_size(bdev) - 1;
> else
> - blksize_mask = (1 << inode->i_blkbits) - 1;
> + blksize_mask = i_blocksize(inode) - 1;
>
> if ((iocb->ki_pos | iov_iter_count(to) |
> iov_iter_alignment(to)) & blksize_mask)
Powered by blists - more mailing lists