linux-kernel - Re: [syzbot] [block?] WARNING in blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9649d501bc8c3444769418f6c26263555d9d3be.camel@linux.ibm.com>
Date:   Mon, 06 Mar 2023 16:00:11 +0100
From:   Julian Ruess <julianr@...ux.ibm.com>
To:     Alexander Egorenkov <egorenar@...ux.ibm.com>,
        syzbot+2bcc0d79e548c4f62a59@...kaller.appspotmail.com
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        jack@...e.cz, yukuai3@...wei.com, hch@....de,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Gerd Bayer <gbayer@...ux.ibm.com>
Subject: Re: [syzbot] [block?] WARNING in blkdev_put (2)

On Thu, 2023-03-02 at 20:33 +0100, Alexander Egorenkov wrote:
> 
> Hi,
> 
> we are seeing a similar problem on s390x architecture when
> partitioning
> a NVMe disk on linux-next.
> 
> 
>   [   70.403015]  nvme0n1: p1
>   [   70.403197] ------------[ cut here ]------------
>   [   70.403199] WARNING: CPU: 8 PID: 2452 at block/bdev.c:845
> blkdev_put+0x280/0x298

...

> The problem appeared about a week ago.
> 
> Regards
> Alex

Hi all,

I bisected this to:

commit e5cfefa97bccf956ea0bb6464c1f6c84fd7a8d9f                       
Author: Yu Kuai <yukuai3@...wei.com>                                  
Date:   Fri Feb 17 10:22:00 2023 +0800                                
                                                                                      
    block: fix scan partition for exclusively open device again       
                                                                                      
    As explained in commit 36369f46e917 ("block: Do not reread
partition table        
    on exclusively open device"), reread partition on the device that
is              
    exclusively opened by someone else is problematic.                
                                                                                      
    This patch will make sure partition scan will only be proceed if
current          
    thread open the device exclusively, or the device is not opened   
    exclusively, and in the later case, other scanners and exclusive
openers          
    will be blocked temporarily until partition scan is done.         
                                                                                      
    Fixes: 10c70d95c0f2 ("block: remove the bd_openers checks in
blk_drop_partitions")
    Cc: <stable@...r.kernel.org>                                      
    Suggested-by: Jan Kara <jack@...e.cz>                             
    Signed-off-by: Yu Kuai <yukuai3@...wei.com>                       
    Reviewed-by: Christoph Hellwig <hch@....de>                       
    Link:
https://lore.kernel.org/r/20230217022200.3092987-3-yukuai1@huaweicloud.com
 
    Signed-off-by: Jens Axboe <axboe@...nel.dk>   



Regards
Julian

-- 
Julian Ruess
Linux on IBM Z Development
IBM Deutschland Research & Development GmbH
Dept 1419, Schoenaicher Str. 220, 71032 Boeblingen,
Vorsitzender des Aufsichtsrats: Gregor Pillen, Geschäftsführung: David
Faller
Sitz der Gesellschaft: Böblingen, Registergericht: Amtsgericht
Stuttgart, HRB 243294
IBM Data Privacy Statement - https://www.ibm.com/privacy