linux-kernel - Re: [PATCH 6/6] ARM: dts: qcom: sdx65-mtp: Enable PCIe EP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27536374-7e13-8a68-fd46-66e833175770@quicinc.com>
Date:   Mon, 6 Mar 2023 20:46:25 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <lee@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <mani@...nel.org>,
        <lpieralisi@...nel.org>, <kw@...ux.com>, <bhelgaas@...gle.com>,
        <manivannan.sadhasivam@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 6/6] ARM: dts: qcom: sdx65-mtp: Enable PCIe EP


On 3/6/2023 4:02 PM, Konrad Dybcio wrote:
>
> On 6.03.2023 06:25, Rohit Agarwal wrote:
>> Enable PCIe Endpoint controller on the SDX65 MTP board based
>> on Qualcomm SDX65 platform.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
>> ---
>>   arch/arm/boot/dts/qcom-sdx65-mtp.dts | 46 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> index 86bb853..952de105 100644
>> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> @@ -252,6 +252,14 @@
>>   	vdda-pll-supply = <&vreg_l4b_0p88>;
>>   };
>>   
>> +&pcie_ep {
>> +	status = "okay";
>> +
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pcie_ep_clkreq_default &pcie_ep_perst_default
>> +			&pcie_ep_wake_default>;
> status last
>
> pinctrl-n goes before pinctrl-names
>> +};
>> +
>>   &qpic_bam {
>>   	status = "okay";
>>   };
>> @@ -276,6 +284,44 @@
>>   	memory-region = <&mpss_adsp_mem>;
>>   };
>>   
>> ++&tlmm {
>> +	pcie_ep_clkreq_default: pcie_ep_clkreq_default {
> No underscores in node names, pinctrl children node names
> must end in -state. Please check your patches against
> "make dtbs_check"
>> +		mux {
>> +			pins = "gpio56";
>> +			function = "pcie_clkreq";
>> +		};
>> +		config {
>> +			pins = "gpio56";
>> +			drive-strength = <2>;
>> +			bias-disable;
>> +		};
> mux {} / config {} is unnecessary. You can simply do:
>
> {
>      pins = "gpio56";
>      function = "pcie_clkreq";
>      drive-strength = <2>;
>      bias-disable;
> };
Thanks for detailed explanation. Will rectify all in the next version.

Thanks,
Rohit.
> Konrad
>> +	};
>> +
>> +	pcie_ep_perst_default: pcie_ep_perst_default {
>> +		mux {
>> +			pins = "gpio57";
>> +			function = "gpio";
>> +		};
>> +		config {
>> +			pins = "gpio57";
>> +			drive-strength = <2>;
>> +			bias-pull-down;
>> +		};
>> +	};
>> +
>> +	pcie_ep_wake_default: pcie_ep_wake_default {
>> +		mux {
>> +			pins = "gpio53";
>> +			function = "gpio";
>> +		};
>> +		config {
>> +			pins = "gpio53";
>> +			drive-strength = <2>;
>> +			bias-disable;
>> +		};
>> +	};
>> +};
>> +
>>   &usb {
>>   	status = "okay";
>>   };