linux-kernel - [PATCH 01/10] scsi: aacraid: Drop redundant pci_enable_pcie_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230307182842.870378-2-helgaas@kernel.org>
Date:   Tue,  7 Mar 2023 12:28:33 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Adaptec OEM Raid Solutions <aacraid@...rosemi.com>,
        Raghava Aditya Renukunta <raghavaaditya.renukunta@...s.com>,
        Tomas Henzl <thenzl@...hat.com>,
        Johannes Thumshirn <jthumshirn@...e.de>
Subject: [PATCH 01/10] scsi: aacraid: Drop redundant pci_enable_pcie_error_reporting()

From: Bjorn Helgaas <bhelgaas@...gle.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Also remove pci_disable_pcie_error_reporting() from the .error_detected()
path, which was added by 5c63f7f710bd ("aacraid: Added EEH support") but
looks unnecessary.  Error reporting will be disabled by the device reset
and will be re-enabled by the pci_restore_state() in aac_pci_slot_reset().

Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Adaptec OEM Raid Solutions <aacraid@...rosemi.com>
Cc: Raghava Aditya Renukunta <raghavaaditya.renukunta@...s.com>
Cc: Tomas Henzl <thenzl@...hat.com>
Cc: Johannes Thumshirn <jthumshirn@...e.de>
---
 drivers/scsi/aacraid/linit.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 5ba5c18b77b4..43160bf4d6a8 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -26,7 +26,6 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/slab.h>
 #include <linux/mutex.h>
 #include <linux/spinlock.h>
@@ -1783,7 +1782,6 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)

 	aac_scan_host(aac);

-	pci_enable_pcie_error_reporting(pdev);
 	pci_save_state(pdev);

 	return 0;
@@ -1949,7 +1947,6 @@ static pci_ers_result_t aac_pci_error_detected(struct pci_dev *pdev,
 		scsi_host_complete_all_commands(shost, DID_NO_CONNECT);
 		aac_release_resources(aac);

-		pci_disable_pcie_error_reporting(pdev);
 		aac_adapter_ioremap(aac, 0);

 		return PCI_ERS_RESULT_NEED_RESET;
-- 
2.25.1