linux-kernel - Re: [Freedreno] [PATCH] drm/msm: fix PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGtgMtRbP9OLh4P+2xL4SnyhP5ROgg2Yt=ZcoAY_+=S7rg@mail.gmail.com>
Date:   Tue, 7 Mar 2023 11:21:35 -0800
From:   Rob Clark <robdclark@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Rob Clark <robdclark@...omium.org>,
        kernel test robot <lkp@...el.com>,
        Paul Gazzillo <paul@...zz.com>,
        Necip Fazil Yildiran <fazilyildiran@...il.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        linux-arm-msm@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        freedreno@...ts.freedesktop.org
Subject: Re: [Freedreno] [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

On Tue, Mar 7, 2023 at 10:48 AM Fabio Estevam <festevam@...il.com> wrote:
>
> On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> >
> > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter
> > should either be selected or DRM_MSM should depend on PM_DEVFREQ.
> > Since most drivers select PM_DEVFREQ instead of depending on it,
> > add a select here to satisfy kconfig.
> >
> > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND
> >   Depends on [n]: PM_DEVFREQ [=n]
> >   Selected by [y]:
> >   - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n)
> >
> > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@...el.com
> > Cc: Rob Clark <robdclark@...omium.org>
> > Cc: Paul Gazzillo <paul@...zz.com>
> > Cc: Necip Fazil Yildiran <fazilyildiran@...il.com>
> > Cc: Chia-I Wu <olvaffe@...il.com>
> > Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Cc: linux-arm-msm@...r.kernel.org
> > Cc: dri-devel@...ts.freedesktop.org
> > Cc: freedreno@...ts.freedesktop.org
>
> This fixes the warning after running 'make imx_v6_v7_defconfig', thanks:
>
> Tested-by: Fabio Estevam <festevam@...il.com>

https://patchwork.freedesktop.org/patch/523353 is the fix we actually
want.. I thought I'd already pulled that into msm-fixes but it seems
like it got lost somewhere.. I'll rectify that

BR,
-R