linux-kernel - RE: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60834C09C9F85D401C2EB0FBFCB79@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Tue, 7 Mar 2023 21:23:00 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Torvalds, Linus" <torvalds@...ux-foundation.org>
CC:     Jakub Jelinek <jakub@...hat.com>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Eranian, Stephane" <eranian@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "peternewman@...gle.com" <peternewman@...gle.com>,
        "james.morse@....com" <james.morse@....com>,
        "babu.moger@....com" <babu.moger@....com>,
        "ananth.narayan@....com" <ananth.narayan@....com>,
        "vschneid@...hat.com" <vschneid@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        clang-built-linux <llvm@...ts.linux.dev>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        "linux-toolchains@...r.kernel.org" <linux-toolchains@...r.kernel.org>
Subject: RE: [PATCH] x86/resctrl: avoid compiler optimization in
 __resctrl_sched_in

> Linux has a lot of "static inline" functions. But that's not at all
> what that function was. It was literally just
>
>   static void __resctrl_sched_in(..)
>
> which is disgusting and very wrong.

Ah. I was looking at:

static inline void resctrl_sched_in(void)
{
        if (static_branch_likely(&rdt_enable_key))
                __resctrl_sched_in();
}

which does have the "inline" attribute.

I wonder if checkpatch could catch missing "inline" on static
function definitions in header files?

-Tony