[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ba3790cb9f3adcb4f7d3935ce9aa88ecacb3bf7d.camel@redhat.com>
Date: Tue, 07 Mar 2023 17:50:30 -0500
From: Lyude Paul <lyude@...hat.com>
To: Jakob Koschel <jkl820.git@...il.com>,
Ben Skeggs <bskeggs@...hat.com>,
Karol Herbst <kherbst@...hat.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
Pietro Borrello <borrello@...g.uniroma1.it>,
Cristiano Giuffrida <c.giuffrida@...nl>,
"Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH 2/2] drm/nouveau/clk: avoid usage of list iterator after
loop
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> + }
> }
>
> + BUG_ON(!pstate);
> nvkm_debug(subdev, "setting performance state %d\n", pstatei);
> clk->pstate = pstatei;
We should probably also replace this with
if (WARN_ON(!pstate)
return -EINVAL;
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
Powered by blists - more mailing lists