linux-kernel - Re: [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75d48dce-192f-0950-8770-839cfb53588b@intel.com>
Date:   Tue, 7 Mar 2023 08:53:02 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Francesco Dolcini <francesco@...cini.it>,
        Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org
Cc:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        linux-kernel@...r.kernel.org, Faiz Abbas <faiz_abbas@...com>
Subject: Re: [PATCH v1] mmc: sdhci_am654: lower power-on failed message
 severity

On 6/03/23 18:27, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> Lower the power-on failed message severity from warn to info when the
> controller does not power-up. It's normal to have this situation when
> the SD card slot is empty, therefore we should not warn the user about
> it.
> 
> Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci_am654.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 7ef828942df3..89953093e20c 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
>  					MAX_POWER_ON_TIMEOUT, false, host, val,
>  					reg);
>  		if (ret)
> -			dev_warn(mmc_dev(host->mmc), "Power on failed\n");
> +			dev_info(mmc_dev(host->mmc), "Power on failed\n");
>  	}
>  }
>