linux-kernel - Re: [PATCH] staging: axis-fifo: alignment should match opening parenthesis in axis-fifo.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2023 09:18:36 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Khadija <kamrankhadijadj@...il.com>
Cc:     Dan Carpenter <error27@...il.com>, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: alignment should match opening
 parenthesis in axis-fifo.c

On Tue, Mar 07, 2023 at 01:10:17PM +0500, Khadija wrote:
> Hey Dan! Thank you for your feedback.
> Yes, the code currently looks unreadable. I am making changes and resending
> the patch.
> Also, on running checkpatch.pl on my patch file I get a warning about 75
> chars per line. Is there a way of fixing it automatically using script?

Hi,

Minor housekeeping notes.  Your email client is sending out html email,
which is rejected by the public mailing lists.  Please reconfigure it to
not do that.

Also, try not to ever top-post like this, it breaks the review process
and makes it impossible at times to determine what you are actually
responding back to.  Read some of the mailing list archives at
lore.kernel.org for examples of the proper way to respond to messages
inline.

thanks,

greg k-h