linux-kernel - Re: [PATCH v2 1/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for G12A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2023 09:47:26 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        jirislaby@...nel.org, neil.armstrong@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        gregkh@...uxfoundation.org,
        Christian Hewitt <christianshewitt@...il.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: amlogic,meson-uart: Add
 compatible string for G12A

On 06/03/2023 20:42, Martin Blumenstingl wrote:
> Amlogic G12A SoCs gained a new "divide XTAL by 2" bit. Everything else
> (we know about) is identical to the UART IP on GX (GXBB/GXL/GXM) SoCs.
> Add a new compatible string for this SoC so this new bit can be managed
> accordingly while keeping "amlogic,meson-gx-uart" as fallback compatible
> string.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
> Changes from v1 -> v2:
> - make meson-gx-uart a valid compatible string for meson-g12a-uart
> 
> 
>  .../bindings/serial/amlogic,meson-uart.yaml   | 28 +++++++++++++------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 3cbdde85ed71..f3af0da8edaf 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -26,21 +26,31 @@ properties:
>    compatible:
>      oneOf:
>        - description: Always-on power domain UART controller
> -        items:
> +        oneOf:
> +          - items:
> +              - enum:
> +                  - amlogic,meson6-uart
> +                  - amlogic,meson8-uart
> +                  - amlogic,meson8b-uart
> +                  - amlogic,meson-gx-uart
> +                  - amlogic,meson-s4-uart
> +              - const: amlogic,meson-ao-uart
> +          - items:
> +              - const: amlogic,meson-g12a-uart
> +              - const: amlogic,meson-gx-uart
> +              - const: amlogic,meson-ao-uart
> +      - description: Everything-Else power domain UART controller
> +        oneOf:
>            - enum:
>                - amlogic,meson6-uart
>                - amlogic,meson8-uart
>                - amlogic,meson8b-uart
>                - amlogic,meson-gx-uart
> +              - amlogic,meson-g12a-uart
>                - amlogic,meson-s4-uart
> -          - const: amlogic,meson-ao-uart
> -      - description: Everything-Else power domain UART controller
> -        enum:
> -          - amlogic,meson6-uart
> -          - amlogic,meson8-uart
> -          - amlogic,meson8b-uart
> -          - amlogic,meson-gx-uart
> -          - amlogic,meson-s4-uart
> +          - items:
> +              - const: amlogic,meson-g12a-uart
> +              - const: amlogic,meson-gx-uart

Difficult to review... You claim you add only g12a which seems like is
happening there but with some other changes. I see g12a three times and
a lot of reshuffling. I also see multiple oneOf, so something is clearly
wrong. oneOf is only one.

Best regards,
Krzysztof